Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RemovePaintState benchmarks #7930

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

screen shot 2019-02-19 at 4 12 49 pm

Copy link
Contributor

@peterqliu peterqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanhamley Changes look good and the bench throws an error as expected 👍 how do we resolve the removePaintState$1 error now that it's no longer silent?

@ryanhamley
Copy link
Contributor Author

@peterqliu You should see the error twice now, once for master and once for the latest release branch. Merging this to master should publish a new version of that to S3 so we'll be down to 1 error. Unfortunately, that won't be resolved until we publish our next release in a couple weeks.

You can work around the release branch for the time being by changing https://github.com/mapbox/mapbox-gl-js/blob/master/bench/versions/index.html#L22 to .then(pkg => [ 'master']))

@ryanhamley ryanhamley merged commit 00d32f8 into master Feb 20, 2019
@ryanhamley ryanhamley deleted the fix-removepaintstate-benchmark branch February 20, 2019 01:40
ryanhamley added a commit that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmarks are broken by RemovePaintState benchmark
2 participants