Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont throw an error for aborted requests #9021

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Dont throw an error for aborted requests #9021

merged 1 commit into from
Nov 26, 2019

Conversation

asheemmamoowala
Copy link
Contributor

Closes #7614.

A Fetch request can be aborted while it is still being read, in which case the resulting exception should be eaten, since it is not caused by an unexpected event.

  • briefly describe the changes in this PR
  • manually test the debug page

Copy link
Contributor

@ryanhamley ryanhamley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ryanhamley
Copy link
Contributor

Actually, wait, I forgot to set up the debug correctly. When I recreate the test case from the ticket, I still see the error in the console

Screen Shot 2019-11-25 at 1 35 19 PM

@asheemmamoowala
Copy link
Contributor Author

@ryanhamley Your screenshot is returning a 404 for sateillite-v11 style which is correct. That style doesn't exist AFAICT.

@asheemmamoowala asheemmamoowala merged commit b9be06e into master Nov 26, 2019
@asheemmamoowala asheemmamoowala deleted the fix-7614 branch November 26, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mapbox gl version 51. The user aborted a request
2 participants