Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor distance calculations #9202

Merged
merged 34 commits into from
Jan 31, 2020
Merged

refactor distance calculations #9202

merged 34 commits into from
Jan 31, 2020

Commits on Jan 17, 2020

  1. refactor distance calculations

    @Meekohi
    Meekohi committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    9c3b2b7 View commit details
    Browse the repository at this point in the history

  2. update LngLat test

    @Meekohi
    Meekohi committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    e8961f4 View commit details
    Browse the repository at this point in the history

  3. updated render-tests

    @Meekohi
    Meekohi committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    2ce2d77 View commit details
    Browse the repository at this point in the history

  4. missed one?

    @Meekohi
    Meekohi committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    f8d0055 View commit details
    Browse the repository at this point in the history

  5. missed a bunch

    @Meekohi
    Meekohi committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    756b094 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2020

  1. Update src/geo/lng_lat.js

    @Meekohi
    Meekohi authored Jan 19, 2020
    Configuration menu
    Copy the full SHA
    e6e1f3d View commit details
    Browse the repository at this point in the history

  2. better comments

    @Meekohi
    Meekohi committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    615dced View commit details
    Browse the repository at this point in the history

  3. update tests again

    @Meekohi
    Meekohi committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    003ac59 View commit details
    Browse the repository at this point in the history

  4. updated inline comment

    @Meekohi
    Meekohi committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    428a861 View commit details
    Browse the repository at this point in the history

  5. better error messages in tests

    @Meekohi
    Meekohi committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    2384d75 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. fix promoteId spec definitions (#9212)

    @mourner
    mourner authored Jan 21, 2020
    Configuration menu
    Copy the full SHA
    87f3393 View commit details
    Browse the repository at this point in the history

  2. upgrade earcut to v2.2.2 (#9214)

    @mourner
    mourner authored and Ryan Hamley committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    a13efc0 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. move earthRadius definition to named export

    @Meekohi
    Meekohi committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    c09c9ec View commit details
    Browse the repository at this point in the history

  2. Fix promoteId for line layers (#9210) 

    * fix promoteId for line layers

* fix promoteId spec definitions (#9212)

* Add render tests for feature state
feature-state/promote-id-line will fail until #9210 is merged

Co-authored-by: Karim Naaji <[email protected]>
    @mourner @karimnaaji @ahk
    2 people authored and ahk committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    28603d1 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2020

  1. Fix line distances breaking gradient across tile boundaries (#9220) 

    * Fix line line distances breaking gradients
Ensure scaled line distance is computed at least once when calculating the entire line distance, otherwise we hit a corner case where the distance isn't updated. Specifically when the beginning of the line doesn't have a sharp corner.
Fixes #8969

* Add render test for line gradient across tile boundaries

* Address review comments
    @karimnaaji @mourner
    karimnaaji authored and mourner committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    980d1fb View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. Update image expression SDK support table (#9228)

    @mourner
    Ryan Hamley authored and mourner committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    b7e8fb3 View commit details
    Browse the repository at this point in the history

  2. Refactor style._load function, move sprite loading to a private method ( 

    #9231)
    @webdeb @kkaefer
    webdeb authored and kkaefer committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    8cd474e View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2020

  1. [tests][tile mode] Add left-top-right-buttom-offset-tile-map-mode test

    @pozdnyakov
    pozdnyakov committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    8c9ace1 View commit details
    Browse the repository at this point in the history

  2. Reduce size of line atlas by removing unused channels (#9232) 

    Saves roughly ~100kb of uncompressed gpu memory, potentially saving texture fetches in the shader
    @karimnaaji
    karimnaaji authored Jan 27, 2020
    Configuration menu
    Copy the full SHA
    be4f189 View commit details
    Browse the repository at this point in the history

  3. Fix a bug where lines with duplicate endpoint disappear on z18+ (#9218) 

    * fix a bug with vanishing line with duplicate end points

* fix flow :(
    @mourner
    mourner authored Jan 27, 2020
    Configuration menu
    Copy the full SHA
    99bfc7f View commit details
    Browse the repository at this point in the history

  4. refactor distance calculations

    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    c913aed View commit details
    Browse the repository at this point in the history

  5. update LngLat test

    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    53aee40 View commit details
    Browse the repository at this point in the history

  6. updated render-tests

    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    4167d3e View commit details
    Browse the repository at this point in the history

  7. missed one?

    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    2da4971 View commit details
    Browse the repository at this point in the history

  8. missed a bunch

    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    c79cd91 View commit details
    Browse the repository at this point in the history

  9. Update src/geo/lng_lat.js

    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    8b1dabd View commit details
    Browse the repository at this point in the history

  10. better comments

    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    e40b6e4 View commit details
    Browse the repository at this point in the history

  11. update tests again

    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    74abf1d View commit details
    Browse the repository at this point in the history

  12. updated inline comment

    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    896c33f View commit details
    Browse the repository at this point in the history

  13. better error messages in tests

    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    9d63de4 View commit details
    Browse the repository at this point in the history

  14. move earthRadius definition to named export

    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    c8edf1c View commit details
    Browse the repository at this point in the history

  15. Merge branch 'lnglat-distance' of github.com:Meekohi/mapbox-gl-js int… 

    …o lnglat-distance
    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    c573758 View commit details
    Browse the repository at this point in the history

  16. update modified render test:

    @Meekohi
    Meekohi committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    25657f0 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2020

  1. wiggle room for HW differences

    @Meekohi
    Meekohi committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    d7ff0fa View commit details
    Browse the repository at this point in the history