Do not warn about exceeding extent when off by 1px #9753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asheemmamoowala
approved these changes
Jun 3, 2020
sgolbabaei
added a commit
that referenced
this pull request
Jun 9, 2020
sgolbabaei
added a commit
that referenced
this pull request
Jun 10, 2020
cowboyox
pushed a commit
to cowboyox/mapbox
that referenced
this pull request
Oct 8, 2024
* Cherry pick (mapbox/mapbox-gl-js#9757) to release-erie * Cherry pick (mapbox/mapbox-gl-js#9753) to release-erie * Cherry pick (mapbox/mapbox-gl-js#9749) to release-erie * Cherry pick (mapbox/mapbox-gl-js#9748) to release-erie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8992. A small change to disable "exceeds extent" warnings when the error is off by just 1 pixel, which currently happens on most of our maps on lower zooms because it originates in Mapbox Streets (where geometry is clipped to extent inclusive on the max boundary when it should be exclusive).
1px-off error won't affect rendering, and having this warning appear by default on our maps makes it look like something's wrong when it's not, so I think this small hack is harmless and beneficial enough to be acceptable. We can remove it later, after our tile sources no longer have this issue.
Launch Checklist
write tests for all new functionalitymapbox-gl-jschangelog:<changelog>Removed a misleading "geometry exceeds allowed extent" warning when using Mapbox Streets vector tiles.</changelog>