Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Updates gl-native submodule to 1.5.0 release #242

Merged
merged 6 commits into from
Mar 26, 2020
Merged

Updates gl-native submodule to 1.5.0 release #242

merged 6 commits into from
Mar 26, 2020

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented Mar 26, 2020 •
edited
Loading

Updates mapbox-gl-native to 1.5.0.
Fixes a pause/resume bug in MGLOfflineStorage introduced in #188.

Also updates darwin.xcconfig accordingly.

@julianrex julianrex changed the title Jrex/update gl native 200326 Updates gl-native submodule to mapbox/mapbox-gl-native/commit/debf11736 Mar 26, 2020
@julianrex julianrex requested review from knov and jmkiley March 26, 2020 15:49
@julianrex julianrex mentioned this pull request Mar 26, 2020
Merged
2 tasks
@julianrex julianrex marked this pull request as ready for review March 26, 2020 16:24
@julianrex julianrex requested a review from 1ec5 as a code owner March 26, 2020 16:24
@julianrex julianrex requested a review from a team March 26, 2020 16:24
@julianrex julianrex added build dependencies Pull requests that update a dependency file labels Mar 26, 2020
1ec5
1ec5 reviewed Mar 26, 2020
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post a draft changelog for the next beta that adds anything developer-facing from mbgl since v1.4.0, namely mapbox/mapbox-gl-native#16319 and mapbox/mapbox-gl-native#16330?

Are any source-level changes needed for the version bump that might not be caught be the compiler? Could any of the changes to the Android JNI code be relevant, such as mapbox/mapbox-gl-native#16334 or the changes to make layers no longer dependent on mbgl::Map? I could handle some of these changes in #235, but it’s unclear how much of them are strictly related to runtime styling in snapshots.

@alexshalamov
Resume thread in MGLOfflineStorage::unpauseFileSource
49011ec 
Fixes pause/resume bug introduced in #188
@julianrex
Copy link
Contributor Author

julianrex commented Mar 26, 2020 •
edited
Loading

This PR is waiting for the release in gl-native and will need to be rebased. /cc @alexshalamov

This will then need to be cherry-picked to release-vanillashake

@julianrex julianrex added this to the release-vanillashake milestone Mar 26, 2020
@julianrex julianrex changed the title Updates gl-native submodule to mapbox/mapbox-gl-native/commit/debf11736 Updates gl-native submodule to 1.5.0 release Mar 26, 2020
@julianrex julianrex merged commit be6574d into master Mar 26, 2020
@julianrex julianrex deleted the jrex/update-gl-native-200326 branch March 26, 2020 23:18
@1ec5 1ec5 mentioned this pull request Apr 6, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@1ec5 1ec5 1ec5 left review comments

@knov knov knov approved these changes

@jmkiley jmkiley Awaiting requested review from jmkiley

Assignees
No one assigned
Labels
build dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
release-vanillashake
Development

Successfully merging this pull request may close these issues.
4 participants
@julianrex @1ec5 @knov @alexshalamov