This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Fixing issue where UIColor with alpha < 1 was being rendered incorrectly #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishant-karajgikar
force-pushed
the
nishantk/alpha-fix
branch
from
4e4d615
to
74455fc
Compare
1ec5
reviewed
Apr 9, 2020
1ec5
reviewed
Apr 15, 2020
Will do, it's weird that there's a change in the |
1ec5
reviewed
Apr 17, 2020
|
|
||
| NSArray *jsonExpression = @[@"rgba", @255.0, @239.0, @213.0, @0.5]; | ||
| NSExpression *papayawhipExpression = [NSExpression expressionWithMGLJSONObject:jsonExpression]; | ||
| MGLColor *papayaWhipColor = [papayawhipExpression expressionValueWithObject:nil context:nil]; |
There was a problem hiding this comment.
By the way, papayawhipExpression is a constant value expression, so this is equivalent to getting its constantValue.
1ec5
reviewed
Apr 20, 2020
Co-Authored-By: Minh Nguyễn <[email protected]>
Co-Authored-By: Minh Nguyễn <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<changelog> Fixed an issue where properties such as MGLFillStyleLayer.fillColor and MGLLineStyleLayer.lineColor misinterpreted non-opaque UIColors.</changelog>Fixes #125
This issue was being caused due to an incorrect assumption that the R, G, B color components needed to be multiplied with the alpha value. The changes fix this by using the newly exposed
mgl_colorForPremultipliedValuecategory method onUIColor.