This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use debug style (currently not using layer compositing)
- Loading branch information
02526f4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come?
02526f4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's easier to visually confirm that label placement works the same way compared to the JS version when using the same stylesheet. Also, the outdoors style in here was really out of date with all the stylesheet changes.
02526f4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's worth looking into mapbox/mapbox-gl-js#655
02526f4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but this yanks the Outdoors style out of current installs without warning. Granted now we have the styles repo open, but technically a hypothetical
0.2.0map has way less detail than the0.1.0.02526f4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does 0.2.0 even mean?
02526f4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the tag on
gl-cocoa;0.1.0was our initial WWDC release. Sure, it's a preview, but it was jarring. Just something to think on going forward. Our screenshots all show an outdoors style as the default to get up & running and explore the tools, but the very day we release GL JS and get eyes on it, we change the default native style to not match these expectations and didn't have thegl-stylesrepo open yet to show alternatives.02526f4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that the default style is something we need to keep consistent across releases. Users will substitute their own stylesheet anyway.
02526f4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default style is pretty important, it leaves the first impression. If a user compiles the app for the first time and doesn't like what he sees, he is likely not to bother with substituting styles.
02526f4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not saying it's unimportant, I'm saying we can change it across versions.