Reversed direction to be clockwise

For consistency with MapKit, the Google Maps SDK, and these methods’ own documentation. Fixes #1780.
mapbox · Jun 25, 2015 · fc209e3 · fc209e3
1 parent 7a30a0d
commit fc209e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/platform/ios/MGLMapView.mm b/platform/ios/MGLMapView.mm
@@ -1463,7 +1463,7 @@ - (void)zoomToSouthWestCoordinate:(CLLocationCoordinate2D)southWestCoordinate no
 
 - (CLLocationDirection)direction
 {
-    double direction = _mbglMap->getBearing() * -1;
+    double direction = _mbglMap->getBearing();
 
     while (direction > 360) direction -= 360;
     while (direction < 0) direction += 360;
@@ -1479,7 +1479,7 @@ - (void)setDirection:(CLLocationDirection)direction animated:(BOOL)animated
 
     CGFloat duration = (animated ? MGLAnimationDuration : 0);
 
-    _mbglMap->setBearing(direction * -1, secondsAsDuration(duration));
+    _mbglMap->setBearing(direction, secondsAsDuration(duration));
 
     [self notifyMapChange:@(animated ? mbgl::MapChangeRegionDidChangeAnimated : mbgl::MapChangeRegionDidChange)];
 }

diff --git a/test/ios/MapViewTests.m b/test/ios/MapViewTests.m
@@ -53,7 +53,7 @@ - (void)testDirectionSet {
                    @"compass should be visible when map is rotated");
 
     XCTAssertEqualObjects([NSValue valueWithCGAffineTransform:tester.compass.transform],
-                          [NSValue valueWithCGAffineTransform:CGAffineTransformMakeRotation(M_PI * 1.5)],
+                          [NSValue valueWithCGAffineTransform:CGAffineTransformMakeRotation(M_PI * 0.5)],
                           @"compass rotation should indicate map rotation");
 }