Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Port line-dasharray fix #16181

Closed
karimnaaji opened this issue Feb 6, 2020 · 0 comments · Fixed by #16202
Closed

Port line-dasharray fix #16181

karimnaaji opened this issue Feb 6, 2020 · 0 comments · Fixed by #16202
Assignees
Labels
GL JS parity For feature parity with Mapbox GL JS

Comments

@karimnaaji
Copy link
Contributor

karimnaaji commented Feb 6, 2020

Port mapbox/mapbox-gl-js#9246 and mapbox/mapbox-gl-js#9232 to native

@karimnaaji karimnaaji added the GL JS parity For feature parity with Mapbox GL JS label Feb 6, 2020
@karimnaaji karimnaaji self-assigned this Feb 11, 2020
karimnaaji added a commit that referenced this issue Feb 12, 2020
* Fix artifact for zero-lenghted dash array
Fixes issue mapbox/mapbox-gl-js#9213 and add
render test for coverage around 0-length dash arrays

Update distance field generation for regular dashes as follows:
1. Compute the dash array ranges and stretch location along the distance field
2. Collapse any 0-length distance field range
3. Collapse neighbouring same-type parts into single part

* combine consecutive dashes and parts

mapbox/mapbox-gl-js#9246
#16181
karimnaaji added a commit that referenced this issue Feb 12, 2020
* Fix artifact for zero-lenghted dash array
Fixes issue mapbox/mapbox-gl-js#9213 and add
render test for coverage around 0-length dash arrays

Update distance field generation for regular dashes as follows:
1. Compute the dash array ranges and stretch location along the distance field
2. Collapse any 0-length distance field range
3. Collapse neighbouring same-type parts into single part

* combine consecutive dashes and parts

mapbox/mapbox-gl-js#9246
#16181
karimnaaji added a commit that referenced this issue Feb 12, 2020
* Fix artifact for zero-lenghted dash array
Fixes issue mapbox/mapbox-gl-js#9213 and add
render test for coverage around 0-length dash arrays

Update distance field generation for regular dashes as follows:
1. Compute the dash array ranges and stretch location along the distance field
2. Collapse any 0-length distance field range
3. Collapse neighbouring same-type parts into single part

* combine consecutive dashes and parts

mapbox/mapbox-gl-js#9246
#16181
karimnaaji added a commit that referenced this issue Feb 13, 2020
* Fix artifact for zero-lenghted dash array
Fixes issue mapbox/mapbox-gl-js#9213 and add
render test for coverage around 0-length dash arrays

Update distance field generation for regular dashes as follows:
1. Compute the dash array ranges and stretch location along the distance field
2. Collapse any 0-length distance field range
3. Collapse neighbouring same-type parts into single part

* combine consecutive dashes and parts

mapbox/mapbox-gl-js#9246
#16181
alexshalamov pushed a commit that referenced this issue Feb 14, 2020
* Fix artifact for zero-lenghted dash array
Fixes issue mapbox/mapbox-gl-js#9213 and add
render test for coverage around 0-length dash arrays

Update distance field generation for regular dashes as follows:
1. Compute the dash array ranges and stretch location along the distance field
2. Collapse any 0-length distance field range
3. Collapse neighbouring same-type parts into single part

* combine consecutive dashes and parts

mapbox/mapbox-gl-js#9246
#16181
alexshalamov pushed a commit that referenced this issue Feb 14, 2020
* Fix artifact for zero-lenghted dash array
Fixes issue mapbox/mapbox-gl-js#9213 and add
render test for coverage around 0-length dash arrays

Update distance field generation for regular dashes as follows:
1. Compute the dash array ranges and stretch location along the distance field
2. Collapse any 0-length distance field range
3. Collapse neighbouring same-type parts into single part

* combine consecutive dashes and parts

mapbox/mapbox-gl-js#9246
#16181
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant