This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Simple polylines & polygons don't appear if initialized with map #2322
Comments
Totally. Something definitely improved the timing issue that did exist, in any case, as |
jfirebaugh
added a commit
that referenced
this issue
Sep 25, 2015
First, move style mutation code out of StyleParser and into AnnotationManager, coalescing it with the mutation code for shape layers. Second, allow AnnotationManager to keep track of stale tiles entirely internally. There's no reason to pass sets of TileIDs around. Third, correct the logic for invalidating the shape source. Since AnnotationManager does not track shape invalidations on a tile-by-tile basis, don't try to invalidate the shape source tile-by-tile. Fixes #1675 Fixes #2322 Fixes #2095
jfirebaugh
added a commit
that referenced
this issue
Sep 28, 2015
First, move style mutation code out of StyleParser and into AnnotationManager, coalescing it with the mutation code for shape layers. Second, allow AnnotationManager to keep track of stale tiles entirely internally. There's no reason to pass sets of TileIDs around. Third, correct the logic for invalidating the shape source. Since AnnotationManager does not track shape invalidations on a tile-by-tile basis, don't try to invalidate the shape source tile-by-tile. Fixes #1675 Fixes #2322 Fixes #2095
AndwareSsj
pushed a commit
to AndwareSsj/mapbox-gl-native
that referenced
this issue
Nov 6, 2015
First, move style mutation code out of StyleParser and into AnnotationManager, coalescing it with the mutation code for shape layers. Second, allow AnnotationManager to keep track of stale tiles entirely internally. There's no reason to pass sets of TileIDs around. Third, correct the logic for invalidating the shape source. Since AnnotationManager does not track shape invalidations on a tile-by-tile basis, don't try to invalidate the shape source tile-by-tile. Fixes mapbox#1675 Fixes mapbox#2322 Fixes mapbox#2095
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Polylines and polygons that don't require much processing before being added to the map fail to ever appear, if initialized concurrently with the map. Adding the slightest delay or drawing the shapes in
viewDidAppear
causes them to appear as expected.The GeoJSON example works when drawn directly in
viewDidLoad
.#2289 fixed this problem for markers
and complex shapes, but I clearly must have missed the simple case during testing.Demo (based on this):
/cc @incanus
The text was updated successfully, but these errors were encountered: