Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Cleanup unused gradle plugins #10211

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Cleanup unused gradle plugins #10211

merged 1 commit into from
Oct 18, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Oct 17, 2017

This PR does some fall cleaning and removes the spoon and AWS Device farm gradle plugin. We aren't using them actively and since they are executed for each gradle invocation. I'm proposing to remove them.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Oct 17, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Oct 17, 2017
@tobrun tobrun self-assigned this Oct 17, 2017
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity:
Did you notice some gain/improvement in the build times?

@tobrun
Copy link
Member Author

tobrun commented Oct 18, 2017

I didn't benchmark it, rough guess would be around or lower than 1 second, considering they were initialized on each run, I feel it's justifiable.

@tobrun tobrun merged commit fe6e0c3 into release-agua Oct 18, 2017
@tobrun tobrun deleted the tvn-fall-gradle-cleaning branch October 18, 2017 09:02
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 19, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
20 tasks
@tobrun tobrun mentioned this pull request Nov 3, 2017
21 tasks
This was referenced Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants