Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Rework test activity gen script setup #10365

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Nov 2, 2017

This PR:

  • add config json to exclude activities from being generated
  • only generate tests if the class has Activity in its name
  • rework output script (see screenshot)

screen shot 2017-11-02 at 09 55 24

Closes #10346

@tobrun tobrun added Android Mapbox Maps SDK for Android tests labels Nov 2, 2017
@tobrun tobrun self-assigned this Nov 2, 2017
@tobrun tobrun requested a review from zugaldia November 2, 2017 16:57
@@ -49,8 +49,9 @@ public void beforeTest() {
throw new RuntimeException("Could not start test for " + getActivityClass().getSimpleName() + ".\n"
+ "The ViewHierarchy doesn't contain a view with resource id = R.id.mapView or \n"
+ "the Activity doesn't contain an instance variable with a name equal to mapboxMap.\n"
+ "You can resolve this issue be implementing the requirements above or\n add "
+ getActivityClass().getSimpleName() + " to the excludeActivities array in `generate-test-code.js`.\n");
+ "You can resolve this issue be adding the requirements above or\n add "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "You can resolve this issue by adding the requirements above or\n by adding"

Copy link
Member

@zugaldia zugaldia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo.

@tobrun tobrun merged commit cc67335 into release-agua Nov 8, 2017
@tobrun tobrun deleted the tvn-activity-gen branch November 8, 2017 08:58
@Guardiola31337 Guardiola31337 mentioned this pull request Nov 14, 2017
22 tasks
@lilykaiser lilykaiser added this to the android-v5.2.0 milestone Nov 15, 2017
@Guardiola31337 Guardiola31337 mentioned this pull request Nov 17, 2017
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants