Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fix UTF-8 encoding, add missing package-info.java files #11261

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Feb 20, 2018

Closes #11260
Closes #11088

cc @ChrisLoer

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Feb 20, 2018
@tobrun tobrun added this to the android-v6.0.0 milestone Feb 20, 2018
@tobrun tobrun self-assigned this Feb 20, 2018
@@ -0,0 +1,4 @@
/**
* Contains the Mapbox Maps Android egl API classes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like "EGL" is usually written in caps (e.g. https://www.khronos.org/egl), so we should probably do the same here?

Copy link
Contributor

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see I wasn't alone in mangling the javadocs... 😳 Is there a tool you use or a configuration option in Android Studio to handle the encoding automatically?

@tobrun
Copy link
Member Author

tobrun commented Feb 20, 2018

Is there a tool you use or a configuration option in Android Studio to handle the encoding automatically?

not afaik, though when generating the docs it will produce an error and we are planning to validate this on CI as part of #9267.

@tobrun tobrun merged commit 278cd58 into release-boba Feb 22, 2018
@tobrun tobrun deleted the tvn-javadoc branch February 22, 2018 13:29
@LukasPaczos LukasPaczos mentioned this pull request Mar 2, 2018
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants