Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Rework logical condition convenience expressions #11555

Merged
merged 2 commits into from
Apr 4, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Mar 29, 2018

When reworking our DDS examples to the new API, we noticed that the current convenience methods of logical conditions of something as eq(String, String) didn't make much sense. This is because IRL you will use at least one expression in there. This PR addresses this by change the syntax to use one epxresssion and one literal value.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Mar 29, 2018
@tobrun tobrun added this to the android-v6.0.0 milestone Mar 29, 2018
@tobrun tobrun self-assigned this Mar 29, 2018
@tobrun tobrun requested a review from LukasPaczos March 29, 2018 13:18
@tobrun tobrun force-pushed the tvn-logical-expressions-rework-api branch from 376cd54 to dd47abd Compare March 29, 2018 13:55
@LukasPaczos LukasPaczos force-pushed the tvn-logical-expressions-rework-api branch from 15a6bdc to dbcbbbe Compare April 4, 2018 09:51
@LukasPaczos LukasPaczos merged commit 5d88441 into release-boba Apr 4, 2018
@LukasPaczos LukasPaczos deleted the tvn-logical-expressions-rework-api branch April 4, 2018 10:41
@LukasPaczos LukasPaczos mentioned this pull request Apr 4, 2018
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants