This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] fix icon-size for small data-driven values #12633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
added
Core
ChrisLoer
approved these changes
Aug 16, 2018
|
Already in master as 33cd094d85 |
friedbunny
removed
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port of mapbox/mapbox-gl-js#7125
Should I add a warning with
Log::Warning(...)? I couldn't find a precedent in -native for this kind of warningThis might need to wait for #12624 because the
generate-style-code.jserrors forformattedright now.