Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

CameraMode transition animation and result listeners #13523

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

LukasPaczos
Copy link
Member

Closes #13243.

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Dec 7, 2018
@LukasPaczos LukasPaczos force-pushed the lp-13243-location-transition-handler branch 3 times, most recently from 10842e7 to f8fe497 Compare December 7, 2018 16:28
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we add some unit tests validating invocation of the callback? optionally one that validates that isTransitioning flag is handled correctly?

Copy link
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasPaczos this looks good to me 👍 agree with @tobrun that adding some tests that verify correct callback trigger would be 💯

@LukasPaczos LukasPaczos force-pushed the lp-13243-location-transition-handler branch from c05077e to b4d9266 Compare December 10, 2018 17:10
@LukasPaczos
Copy link
Member Author

Tests have been revisited and I'd love another round of 👀 on them if possible before merging, thanks!

Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LukasPaczos LukasPaczos merged commit d592889 into master Dec 12, 2018
@LukasPaczos LukasPaczos deleted the lp-13243-location-transition-handler branch December 12, 2018 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants