This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Query when renderer is being recreated #14395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eatures when resuming Activity
…y depending on map/surface state
tobrun
force-pushed
the
tvn-query-when-no-surface
branch
from
ab14a3f
to
70b929e
Compare
LukasPaczos
approved these changes
Apr 11, 2019
...TestApp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/maplayout/SimpleMapActivity.java
Outdated
Show resolved
Hide resolved
tobrun
force-pushed
the
tvn-query-when-no-surface
branch
4 times, most recently
from
ce94393
to
7994ad3
Compare
…without surface crash
tobrun
force-pushed
the
tvn-query-when-no-surface
branch
from
7994ad3
to
7b7f897
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14394, this PR hardens querying the map when the underlying surface is being recreated. With 7.3.0, we changed the lifespan of the renderer to match the surface (instead of the MapView). This change resulted in that the API found on our core renderer isn't usable directly after resuming an Activity. Checking if we have a surface solves that but this is something we need to revisit in the long run in a cleaner way.
This PR adds a regression test, additional javadoc explaining the issue and the actual fix.
cc @Guardiola31337