This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] No pending requests for already requested images. #15864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on the testcase that previously hung - this is looking good ✅ |
|
@springmeyer thanks a lot for your time on testing this! |
…missing image" This reverts commit 2213268.
so that processing for the corresponding tile does not suspend and the rendering performance is not affected.
pozdnyakov
force-pushed
the
mikhail_pending_image_requests
branch
from
ff3af72
to
7ba3996
Compare
pozdnyakov
force-pushed
the
mikhail_pending_image_requests
branch
from
7ba3996
to
ba44858
Compare
alexshalamov
approved these changes
Oct 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #15497 in a different way comparing to the reverted #15778: instead of coalescing requests we just do not treat requests for already requested images as pending (i.e. waiting to be dispatched to the client).
This is a safer approach, which obviates regressions like mapbox/api-gl#1404 (caused by the missing
rendererFrontend.update()calls) - a dedicated unit test is added to verify the behavior.