Commits on Nov 19, 2019

1. [core] fix rendering of dashed lines with round caps …

   In #15862, we introduced individual textures for line dash patterns to eliminate atlas overflows. Unfortunately, this broke dashed lines that had round caps (dashed lines with straight caps still rendered correctly). Line pattern textures for round caps were now using 256×15 pixel textures.
   
   The OpenGL ES 2.0 spec, section 3.8.2 states:
   
       Calling a sampler from a fragment shader will return `(R,G,B,A) = (0,0,0,1)` if any of the following conditions are true:
       […]
       - A two-dimensional sampler is called, the corresponding texture image is a non-power-of-two image […], and either the texture wrap mode is not `CLAMP_TO_EDGE`, or the minification filter is neither `NEAREST` nor `LINEAR`.
       […]
   
   This means that texture lookups won't work for NPOT textures unless they use `GL_CLAMP_TO_EDGE`. We're using `GL_CLAMP_TO_EDGE` for the vertical direction, but GL_REPEAT for the horizontal direction, which means that we need a power-of-two texture for our line dash patterns to work on OpenGL ES 2.0 conforming implementations. Fortunately, this just means changing the height from 15 to 16, and from 30 to 32, so we don't waste many pixels.

   

   kkaefer committed Nov 19, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 7ffc5e0
   • Browse repository at this point

   Copy the full SHA

   7ffc5e0 View commit details

   Browse the repository at this point in the history