[core] Global settings API #16174

alexshalamov · 2020-02-03T21:23:24Z

Global settings API provides means of managing non-persistent in-process settings. Initial implementation contains support for experimental option for setting thread priorities.

GL-native keys have mapbox_ prefix. For instance "mapbox_thread_priority_worker"

Example:

auto& settings = Settings::getInstance();

// Sets thread priority value for worker threads
settings.set(EXPERIMENTAL_THREAD_PRIORITY_WORKER, Value{19.0});

// Gets thread priority value for worker threads
auto value = settings.get(EXPERIMENTAL_THREAD_PRIORITY_WORKER);

Launch Checklist

briefly describe the changes in this PR
write tests for all new functionality
document any changes to public APIs
tagged @mapbox/maps-android @mapbox/maps-ios @mapbox/core-sdk if this PR adds or updates a public API
apply needs changelog label if a changelog is needed (remove label when added)

/cc @mapbox/core-sdk @brunoabinader @mr1sunshine @nagineni

include/mbgl/platform/settings.hpp

include/mbgl/util/thread.hpp

src/mbgl/platform/settings.cpp

include/mbgl/platform/settings.hpp

include/mbgl/util/thread_priority_setter.hpp

include/mbgl/platform/settings.hpp

…threads

Change container types where number of elements expected to be rather small. For instance, number of offline packs or sql statements.

alexshalamov force-pushed the alexshalamov_global_settings branch 4 times, most recently from bf9e2b6 to 98bfdb1 Compare February 5, 2020 11:48

alexshalamov marked this pull request as ready for review February 5, 2020 12:32

alexshalamov requested a review from 1ec5 as a code owner February 5, 2020 12:32

alexshalamov requested review from pozdnyakov and tmpsantos and removed request for 1ec5 February 5, 2020 12:32

alexshalamov added the needs changelog Indicates PR needs a changelog entry prior to merging. label Feb 5, 2020

pozdnyakov reviewed Feb 6, 2020

View reviewed changes

alexshalamov added 3 commits February 6, 2020 12:50

[core] Add global settings object

f36b183

[core] Add unit test for global settings object

ca0063b

[core] Add platform::setCurrentThreadPriority(double)

b9ce73a

alexshalamov force-pushed the alexshalamov_global_settings branch 2 times, most recently from 2e5cbb7 to 2fbd46f Compare February 6, 2020 15:24

pozdnyakov approved these changes Feb 6, 2020

View reviewed changes

alexshalamov added 3 commits February 6, 2020 22:33

[core] Add hooks for setting experimental thread priorities for mbgl …

291fdcf

…threads

[core] Switch unordered_map to map

32e377d

Change container types where number of elements expected to be rather small. For instance, number of offline packs or sql statements.

[core] Update changelog

9d0e2ef

alexshalamov force-pushed the alexshalamov_global_settings branch from 2fbd46f to 9d0e2ef Compare February 6, 2020 20:33

alexshalamov removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Feb 6, 2020

alexshalamov merged commit d915e77 into master Feb 6, 2020

alexshalamov deleted the alexshalamov_global_settings branch February 6, 2020 21:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Global settings API #16174

[core] Global settings API #16174

alexshalamov commented Feb 3, 2020 •

edited

Loading

[core] Global settings API #16174

[core] Global settings API #16174

Conversation

alexshalamov commented Feb 3, 2020 • edited Loading

Example:

Launch Checklist

alexshalamov commented Feb 3, 2020 •

edited

Loading