This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Fix sprite sheet merging in Style::Impl::onSpriteLoaded #16211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
added
the
needs changelog
alexshalamov
force-pushed
the
alexshalamov_fix_merge_spritesheets
branch
3 times, most recently
from
11c3fb3
to
0645140
Compare
alexshalamov
removed
the
needs changelog
mr1sunshine
reviewed
Feb 16, 2020
mr1sunshine
reviewed
Feb 16, 2020
If we get a new sprite sheet from the server, we need to merge current sprite sheet with a new one, while overwiting duplicates and keeping old unique images in a style.
alexshalamov
force-pushed
the
alexshalamov_fix_merge_spritesheets
branch
from
4649732
to
6cbac58
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we get a new sprite sheet from the server, we need to merge current sprite sheet with a new one, while overwriting duplicates and keeping old unique images in a style.
Launch Checklist
needs changeloglabel if a changelog is needed (remove label when added)