This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] [tile mode] placement algorithm must consider icons bounding boxes #16277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link to the render test PR: mapbox/mapbox-gl-js#9382 |
alexshalamov
previously approved these changes
Mar 5, 2020
alexshalamov
reviewed
Mar 5, 2020
Tile mode placement algorithm now checks if bounding boxes for both label text and icon are intersecting the edges of the tiles. Before, it checked only text bounding boxes and thus label icons might have got cut off.
pozdnyakov
force-pushed
the
mikhail_tile_mode_icons_placement
branch
2 times, most recently
from
0eefa30
to
49b55de
Compare
alexshalamov
approved these changes
Mar 6, 2020
so that it includes `tile-mode/streets-v11` test
pozdnyakov
force-pushed
the
mikhail_tile_mode_icons_placement
branch
from
49b55de
to
fdaaa17
Compare
pozdnyakov
force-pushed
the
mikhail_tile_mode_icons_placement
branch
2 times, most recently
from
e3d32d0
to
b0fa6d7
Compare
Due to flaky metrics results
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tile mode placement algorithm now checks if bounding boxes for both label text and icon are intersecting the edges of the tiles.
Before, it checked only text bounding boxes and thus label icons might have got cut off.
Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/200