[android] Add hole handling to PolygonOptions #5170
Conversation
nealsanche
commented
May 27, 2016
nealsanche
commented
- Added holes to the Java SDK, JNI, and renderer
- Multiple holes are supported
- Seems stable even if no holes are specified
- Added code to add holes in the Polygon demo app which adds 3 holes to the star over portland.
|
Could you rebase and force-push your changes (fetch upstream master, then rebase the feature branch atop master, then push --force)? Since you last updated your branch, we made a major change down in C++ land (replacing include guards with |
|
/cc @tobrun |
|
/cc @jfirebaugh |
nealsanche
force-pushed
the
feature/polygon_holes
branch
from
d6f9dde
to
0daa443
Compare
|
@1ec5: I did a rebase just now and force pushed. |
| jni::jobject* holes = jni::GetField<jni::jobject*>(*env, polygon, *polygonHolesId); | ||
| mbgl::AnnotationSegments holeSegments = annotation_segments_from_jlist_of_latlng_jlist(env, holes); | ||
| jni::DeleteLocalRef(*env, holes); | ||
| mbgl::Log::Debug(mbgl::Event::JNI, "H-H"); |
There was a problem hiding this comment.
Left in a silly log statement here. Whoops. I'll nuke that guy.
|
Thanks for rebasing, @nealsanche. I’m wondering if you’ve seen #5110, d0ea7c3 in particular. |
|
OK, #5110 is merged. |
|
Alright. I will have a look into porting these changes, likely Monday. On Sat, May 28, 2016, 12:21 AM Minh Nguyễn [email protected] wrote:
Robots and Pencils Inc | 1507 14th Ave SW Calgary AB T3C 0W4 |
nealsanche
force-pushed
the
feature/polygon_holes
branch
from
1b0f595
to
d137f10
Compare
- Added holes to the Java SDK, JNI, and renderer
nealsanche
force-pushed
the
feature/polygon_holes
branch
from
d137f10
to
d1a0645
Compare
|
@1ec5: Alright, I've updated the Android JNI code to use the simplified method of just appending the holes to the shell segment. Seems to be working. |
1ec5
added
Android
|
@1ec5: So, I took a look at the conflicts here today. So much has changed in the JNI layer that I'm not sure where to go with all of this. I'm assuming that this branch is going to dead end, and that the holes API will be implemented in another branch? |
|
With all the things moving in both mbgl and the Android SDK, unfortunately, that’s probably the case. @bleege can comment on whether polygon hole support is something we can get into an upcoming Android SDK release, or whether it’ll have to wait until the next release cycle. Thank you for taking the time to make this PR, in any case. |
|
I suspect, even with the current changes, that the code delta to add polygons with holes to Android would quite small. I would just have to spend a lot more time that one of your team members to make the adaptations. |
|
@nealsanche Thanks so much for inquiring about this (and writing code!). We're currently putting the finishing touches on the Android 4.1.0 release so we're reluctant to add new features this late in that stage. We'll be starting to think abotu Android 4.2.0 soon though and will be happy to consider it at that time. Thanks again! |
|
I made an attempt at reviving this PR in #7397. |
