-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
@tobrun, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bleege, @ivovandongen and @cammace to be potential reviewers. |
5ebdc95
to
4015c1a
Compare
@ivovandongen do you want to review? |
@tobrun Great stuff! I do get some failures though: See log output |
@ivovandongen thank you for testing, this was on a Nexus 5x? |
@tobrun Yes, sorry. It's my 5x with latests os updates. |
9314e37
to
c63347c
Compare
c63347c
to
9491b9b
Compare
I resolved the merging conflicts, @ivovandongen want to review? |
9491b9b
to
cd795d7
Compare
@tobrun I'm getting some compile errors on a fresh checkout of this branch:
|
those seems regressions from #6894, fixing up |
cd795d7
to
e3d78fe
Compare
@ivovandongen fixed up the rebase issue with e3d78fe. |
@tobrun One last failure in
|
…ity class, remove inheritance in runtime style test update gitignore for generated tests add camera move test add realtime geojson to be excluded when generating Activity sanity tests by default show workaround for showing a MapView in a dialog add annotation tests remove older camera tests, introduce tests for move, ease and animate, bring back setLatLng and getLatLng on MapView, add tests for internal camera API. compass view tests add tests for attribution and logo. fix annotation tests Rename Actiivity test class, split up annotation tests, added MarkerView tests, added infowindow tests, added MyLocationView tests fix addRemoveLayer test by integrating map interactions inside a ViewAction
e3d78fe
to
13b4b44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
WIP to cover a big part of our public API with instrumentation tests. This will help us start refactor work from https://github.com/mapbox/mapbox-gl-native/projects/4 without breaking the whole API.
Initial focus: