This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Use the rawLayer pointer to access the mbgl layer #6966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous refactor neglected to remove the unused `layer` property. This removes that property and uses the rawLayer property that actually points to the mbgl layer.
boundsj
added
iOS
|
I noticed this while responding to #6959 |
1ec5
approved these changes
Nov 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6904 renamed the
layerproperty torawLayer. The subclasses ofMGLStyleLayerwere all updated to userawLayerbut theMGLStyleLayeritself was not. So, common functionality like setting visibility caused a crash.This removes the
layerproperty inMGLStyleLayeritself and uses therawLayerproperty that actually points to the mbgl layer.cc @1ec5