This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix runtime styling deprecation warnings #7972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
build
iOS
|
@1ec5, thanks for your PR! By analyzing this pull request, we identified @boundsj, @friedbunny and @jfirebaugh to be potential reviewers. |
1ec5
force-pushed
the
1ec5-dds-test-deprecation
branch
from
63fd78e
to
8d18c5e
Compare
boundsj
approved these changes
Feb 8, 2017
There was a problem hiding this comment.
This looks good. Some new tests were added to check that MGLStyleFunction instances convert to camera functions when set to properties so those should be moved and their warnings ignored, too.
1ec5
force-pushed
the
1ec5-dds-test-deprecation
branch
from
8d18c5e
to
fa4cabf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed deprecation warnings in macosapp and the Darwin tests that were introduced in #7785 and #7596, other than the warnings being fixed in #7960. I ended up fixing the warnings in the tests by porting the tests from Swift to Objective-C, where I could suppress the warnings using a
#pragmastatement./cc @fabian-guerra