This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Don't treat empty raster tiles as valid #8164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkaefer, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh to be potential reviewers. |
kkaefer
force-pushed
the
overzoom-raster-tiles
branch
from
6ec6f52
to
8f267f9
Compare
jfirebaugh
approved these changes
Feb 22, 2017
This was referenced Apr 19, 2017
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently treating raster tiles that are "empty" or not found as valid by setting
DataAvailability::All. Tiles that can't be found on the server and that return a 404 code are treated as valid responses with no content ("empty").While the concept of an "empty" tile makes sense for vector sources (denoting no features within that tile), it doesn't make sense for raster sources. Instead, we should fall back to lower zoom level tiles. Our
updateRenderablesalgorithm takes care of loading these lower zoom level tiles iff the loaded tile can't be rendered.Fixes #8151