Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] - Style wide transition options in milliseconds #8576

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Mar 30, 2017

Closes #8575

cc @incanus

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Mar 30, 2017
@tobrun tobrun added this to the android-v5.1.0 milestone Mar 30, 2017
@tobrun tobrun self-assigned this Mar 30, 2017
@tobrun tobrun force-pushed the 8575-style-transitionoptions-in-ms branch 2 times, most recently from 6e5fc20 to 74be2bd Compare March 30, 2017 08:08
@tobrun tobrun force-pushed the 8575-style-transitionoptions-in-ms branch from 74be2bd to 3238dc4 Compare March 30, 2017 08:12
Copy link
Contributor

@ivovandongen ivovandongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Wonder if this requires a major version increase though..

*/
@UiThread
public void setTransitionDuration(long duration) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we consider this a breaking change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use java.time.Duration for durations and avoid unit bugs through type safety?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ivo mentioned the same on chat regards using Duration from joda.time, will ticket it out.

@tobrun tobrun merged commit a495913 into master Mar 30, 2017
@tobrun tobrun deleted the 8575-style-transitionoptions-in-ms branch March 30, 2017 11:26
@tobrun tobrun mentioned this pull request May 2, 2017
12 tasks
@tobrun tobrun mentioned this pull request Jun 9, 2017
12 tasks
@tobrun tobrun mentioned this pull request Jun 21, 2017
11 tasks
@tobrun tobrun mentioned this pull request Jun 30, 2017
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants