Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] - add Map change & visibility test activities #9425

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jul 5, 2017

Follow up from #9412, While that PR didn't make the cut, it contained 2 useful test activities.
Adding them as a separate PR.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jul 5, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Jul 5, 2017
@tobrun tobrun self-assigned this Jul 5, 2017
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ni details.

}

private String resolveMapChange(int change) {
switch (change) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using a map/dictionary instead of switch?


@Override
public void run() {
if (mapView != null && viewParent != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about simplifying this chain of if else? Expressions are hard to read/follow.

@tobrun tobrun force-pushed the tvn-additional-test-activities branch from 22ba7cd to a04e3e3 Compare July 6, 2017 20:43
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tobrun tobrun merged commit 950ab7e into master Jul 7, 2017
@tobrun tobrun deleted the tvn-additional-test-activities branch July 7, 2017 08:36
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 6, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 19, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
20 tasks
@tobrun tobrun mentioned this pull request Nov 3, 2017
21 tasks
This was referenced Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants