This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Implement property functions for line-join, text-justify, text-anchor #9583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
approved these changes
Jul 21, 2017
src/mbgl/text/shaping.cpp
Outdated
| @@ -195,13 +195,62 @@ std::set<std::size_t> determineLineBreaks(const std::u16string& logicalInput, | |||
| return leastBadBreaks(evaluateBreak(logicalInput.size(), currentX, targetWidth, potentialBreaks, 0, true)); | |||
| } | |||
|
|
|||
| struct AnchorAlignment { | |||
There was a problem hiding this comment.
Since this struct is only used as a temporary variable on the stack, how about just inlining getAnchorAlignment where it's used and replacing the AnchorAlignment variable with separate horizontalAlign and verticalAlign variables?
ChrisLoer
approved these changes
Jul 24, 2017
|
I added ignores for DDS line-join tests in #9612 so you'll want to un-ignore those when you rebase. |
added 6 commits
July 26, 2017 12:16
…ne-join, text-anchor, text-justify
|
I also un-ignored |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started down the path of porting mapbox/mapbox-gl-js#5020 to native, but because of the spec-based generated code figured I may as well port mapbox/mapbox-gl-js#4997 and mapbox/mapbox-gl-js#5000 here as well.
Closes #9555.
Closes #9559.
This is based on the gl-js SHA in mapbox/mapbox-gl-js#5020 — remaining TODO here is to update the sdk-support tables in gl-js for these properties.