Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Default max zoom 22 #9835

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Default max zoom 22 #9835

merged 1 commit into from
Aug 22, 2017

Conversation

asheemmamoowala
Copy link
Contributor

@asheemmamoowala asheemmamoowala commented Aug 22, 2017

Update iOS documentation and use DEFAULT_MAX_ZOOM constant.
+CHANGELOGs

Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an entry to the Android, iOS, and macOS changelogs about the increased maximum maximum? Thanks!

@@ -508,7 +508,9 @@ public double getMinZoomLevel() {
* <p>
* Sets the maximum zoom level the map can be displayed at.
* </p>
*
* <p>
* The default maximum zoomn level is 22. The upper bound for this value is 25.5.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: “zoomn”.

@@ -597,7 +597,8 @@ MGL_EXPORT IB_DESIGNABLE
* If the value of this property is smaller than that of the
* minimumZoomLevel property, the behavior is undefined.
*
* The default maximumZoomLevel is 20.
* The default maximumZoomLevel is 22. The upper bound for this property
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property names should be in backticks to benefit from jazzy’s autolinking feature. However, let’s say “default value of this property” here for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ec5 - In this case its referring to itself, so this shouldn't need any linking.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that’s why I suggested saying “default value of this property”, same as what you had written for macOS. No big deal though.

@friedbunny
Copy link
Contributor

Are there any prerequisites or blockers that would keep these maxzoom changes from being cherry-picked into the current release branch?

@asheemmamoowala
Copy link
Contributor Author

@friedbunny - I think #9820 and #4168 (for Android only) should be looked at to make sure they are either acceptable or not an issue.

@asheemmamoowala asheemmamoowala merged commit f2c9f2b into master Aug 22, 2017
@asheemmamoowala asheemmamoowala deleted the default-max-zoom-22 branch August 22, 2017 23:50
@friedbunny friedbunny added Android Mapbox Maps SDK for Android Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS Node.js node-mapbox-gl-native labels Aug 23, 2017
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 6, 2017
20 tasks
@Guardiola31337 Guardiola31337 added this to the android-v5.2.0 milestone Oct 6, 2017
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 19, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
20 tasks
@tobrun tobrun mentioned this pull request Nov 3, 2017
21 tasks
This was referenced Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS Node.js node-mapbox-gl-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants