This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Fix heading update loop #9845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
force-pushed
the
fb-fewer-heading-updates-thx
branch
from
cf49dc3
to
771bf4b
Compare
1ec5
approved these changes
Aug 23, 2017
frederoni
approved these changes
Aug 24, 2017
Updating CLLocationManager.headingOrientation triggers a new heading update, even if there was no actual change in its value.
friedbunny
force-pushed
the
fb-fewer-heading-updates-thx
branch
from
771bf4b
to
b2fd7b6
Compare
|
Filed rdar://34059173 and updated the comment in code. |
This was referenced Aug 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9822, significantly reducing CPU usage during user heading tracking mode.
In #7716, we started calling
layoutSubviewsmore often. If the compass were visible, this would then callupdateHeadingForDeviceOrientation, which would setCLLocationManager.headingOrientation.Even if there is no actual change in its value, setting
CLLocationManager.headingOrientationtriggers a new heading update, which in turn caused us to update the user location annotation andlayoutSubviewsagain. This effectively disabled the heading filter and the loop would continue until heading tracking mode was disabled./cc @frederoni @fabian-guerra @1ec5