This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix line label rendering glitch for overzoomed tiles #9865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… doesn't always pick up the default type of 'double' from util::mag.
Ports fix for GL JS issue #5112. Line label projection can't be based on tile geometry that's behind the plane of the camera. The relevant tests are still ignored because the overzoomed collision behavior is different between native and JS.
There was a problem hiding this comment.
The original issue from #5112 is fixed.
I think as a result though, there are more label placements happening at the top end of a pitched view, and sometimes seeing overlap there:
Yeah, I'd file that under "collision detection doesn't work very well on overzoomed tiles". Working on it! |
asheemmamoowala
approved these changes
Aug 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #9843, port of mapbox/mapbox-gl-js#5112.
Unfortunately, the tests are still ignored. The rendering is working, but the collision detection for overzoomed tiles is somewhat different between native and JS (and broken in both cases, see: mapbox/mapbox-gl-js#5095 and mapbox/mapbox-gl-js#5072). This should be addressed as part of the viewport collision refactoring.
@asheemmamoowala, you originally found this problem while playing with overzooming on native, so it would be nice if you could play around with the patch as well. I spent some time with the original "Figueroa St." case and everything seems to be working as expected.
/cc @anandthakker @asheemmamoowala @ansis