Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating styles from streets-v6 to streets-v7 #243

Closed
wants to merge 47 commits into from

Conversation

xrwang
Copy link
Contributor

@xrwang xrwang commented Jan 28, 2016

#233

All styles with exception of Emerald.

@ajashton
Copy link
Member

These will also need updated sprite images for the new maki icons, shields, and rail networks (where applicable).

@nickidlugash
Copy link
Contributor

@xrwang I started manually updating the Streets style, and noticed the following schema changes missing from the migration. I'm including these in my manual update to Streets, but just wanted to flag in case it's helpful for the other styles :) Do you want to update the migration script? If not we can just use the list below to doublecheck the other styles as we manual update them.

Breaking Streets style:

  • rail labels not showing up (moved to rail_station_label from poi_label)
  • airport labels not showing up (moved to airport_label from poi_label)
  • islands and islet labels not showing up (moved to place_label from poi_label. Also note the change in case: Island => island, Islet => islet)
  • some road labels wrongly styled (road_label classes should match the new road classes)
  • national_park are not styled (they have moved to own class in landuse_overlay – previously part of the park class of landuse)
  • construction road, tunnels, and bridges not showing up (all three filters are incorrect in different ways, however).
  • tunnels are styled as roads (all regular roads need to be filtered by structure=none)
  • trunks not showing up (filtering needs to change from type=trunk to class=trunk)
  • street layers wrongly filtered (for some reason these now all have filters of motorway_link, street, street_limited, service, path, pedestrian, or track).
  • oneway arrows not showing up (values for oneway field changed from 0 and 1 to true and false

Not breaking:

  • remove all rail and airport maki values from poi_label filters, remove Island and Islet type values from poi_label filters
  • driveway is no longer a road class (move to part of service class) – not breaking in Streets because driveways and service roads were already in one style layer.

@xrwang
Copy link
Contributor Author

xrwang commented Feb 4, 2016

thanks for catching @nickidlugash, please continue to 🎏 ! i'll include my notes here as well.

@xrwang
Copy link
Contributor Author

xrwang commented Feb 5, 2016

On primary, secondary and tertiary roads, links are missing
primary_link, secondary_link, tertiary_link (for bridge, tunnel, etc)

@xrwang
Copy link
Contributor Author

xrwang commented Feb 16, 2016

Per chat with @amyleew Style Merge Master '16, since each of the styles have been massaged by different folks, we're going to:

Keep file name the same for each style, no migrated tag
Make each style on its own branch
Merge down the branch and delete

Closing this PR

@xrwang xrwang closed this Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants