basic style updated to mbsv7, massaged version, ready to merge #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooo, how are spritesheets created? For some reason I thought it referenced a folder, ie https://github.com/mapbox/mapbox-gl-styles/tree/master/sprites. |
28 tasks
amyleew
changed the title
|
@amyleew FYI making a couple of updates right , including updated sprites. |
|
Sounds good @nickidlugash 👍 |
|
@amyleew this should be good to go 👍 Only outstanding issue is that when the stylesheet was downloaded from Studio, the ordering of the layer properties in the style sheet became weird/inconsistent. Hopefully we can resolve this issue before merging in (but I'll leave that decision up to you). |
|
@amyleew ^ made one final update! |
|
👍 |
amyleew
added a commit
that referenced
this pull request
Feb 23, 2016
basic style updated to mbsv7, massaged version, ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #233 and #249, updates for
basicmap style.Still needs:spritesheet (how exactly is this created?)created inapi-coreaddmetadata/mapbox:groupfor optimization (good idea for such a small style?)/cc @xrwang @nickidlugash @yhahn @ajashton