Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reference table of standard icons #318

Merged
merged 9 commits into from
Jul 22, 2016
Merged

Add a reference table of standard icons #318

merged 9 commits into from
Jul 22, 2016

Conversation

lucaswoj
Copy link

@lucaswoj lucaswoj commented Jul 22, 2016

fixes #241

A common user request is a quick reference guide of the standard icons in Mapbox styles. I think this'll be a big help to our users and a minimal maintenance burden to us.

(Apologies for the HTML rat's nest. I wanted to avoid having a header on my table which requires going full HTML)

Preview the new README here: https://github.com/mapbox/mapbox-gl-styles/tree/icon-reference#standard-icons

@samanpwbb
Copy link
Contributor

This is great! Is there any way we can automate generating this table by using the https://github.com/mapbox/maki project? Otherwise, this will be difficult to keep up to date.

@lucaswoj
Copy link
Author

It'd be possible to write a script to automatically generate this table but the script would have to be run manually every time there's a change.

Is our intention to have a 1:1 mapping between the set of Maki icons and our "standard" icons? Do you expect the set of standard icons to change in the future?

@samanpwbb
Copy link
Contributor

samanpwbb commented Jul 22, 2016

It'd be possible to write a script to automatically generate this table but the script would have to be run manually every time there's a change.

Running it manually would be fine.

Is our intention to have a 1:1 mapping between the set of Maki icons and our "standard" icons? Do you expect the set of standard icons to change in the future?

The icons change with each mapbox streets source version release to match what's in the vector tile's maki field: https://www.mapbox.com/vector-tiles/mapbox-streets-v7/#poi_label. We always create maki icons for every possible field.

@lucaswoj
Copy link
Author

Ready to 🚢 @samanpwbb?

@samanpwbb
Copy link
Contributor

Looks great to me!

@samanpwbb
Copy link
Contributor

You might want to add a little caveat somewhere:

The following icons are used in the POI layer in the Mapbox Streets-v7 data source and will be available in all Mapbox default and template styles. Styles may have additional icons in their sprites beyond those in this table.

@nickidlugash
Copy link
Contributor

The following icons are used in the POI layer in the Mapbox Streets-v7 data source

Caveat to the caveat: These layers also use maki icons:

@lucaswoj lucaswoj merged commit 322855f into master Jul 22, 2016
@lucaswoj
Copy link
Author

Let's keep it simple. Users don't need those implementation details to use our standard icons. We can iterate on this later if there's any confusion.

@lucaswoj lucaswoj deleted the icon-reference branch July 22, 2016 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add standard icons and glyphs to all Mapbox styles
3 participants