-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a reference table of standard icons #318
Conversation
This is great! Is there any way we can automate generating this table by using the https://github.com/mapbox/maki project? Otherwise, this will be difficult to keep up to date. |
It'd be possible to write a script to automatically generate this table but the script would have to be run manually every time there's a change. Is our intention to have a 1:1 mapping between the set of Maki icons and our "standard" icons? Do you expect the set of standard icons to change in the future? |
Running it manually would be fine.
The icons change with each mapbox streets source version release to match what's in the vector tile's |
Ready to 🚢 @samanpwbb? |
Looks great to me! |
You might want to add a little caveat somewhere:
|
Caveat to the caveat: These layers also use maki icons: |
Let's keep it simple. Users don't need those implementation details to use our standard icons. We can iterate on this later if there's any confusion. |
fixes #241
A common user request is a quick reference guide of the standard icons in Mapbox styles. I think this'll be a big help to our users and a minimal maintenance burden to us.
(Apologies for the HTML rat's nest. I wanted to avoid having a header on my table which requires going full HTML)
Preview the new README here: https://github.com/mapbox/mapbox-gl-styles/tree/icon-reference#standard-icons