Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to fix compilation error and added internal route line activity. #4301

Merged
merged 1 commit into from
May 26, 2021
Merged

Update to fix compilation error and added internal route line activity. #4301

merged 1 commit into from
May 26, 2021

Conversation

cafesilencio
Copy link
Contributor

@cafesilencio cafesilencio commented Apr 21, 2021 •
edited
Loading

Description

Update QA testing app. to fix compilation error and added internal route line activity.

Screenshots or Gifs

@cafesilencio cafesilencio added the skip changelog Should not be added into version changelog. label Apr 21, 2021
@cafesilencio cafesilencio marked this pull request as draft April 21, 2021 23:09
@cafesilencio cafesilencio marked this pull request as ready for review April 21, 2021 23:18
@cafesilencio cafesilencio requested a review from a team April 21, 2021 23:18
LukasPaczos
LukasPaczos approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to remove the one in the examples?

@cafesilencio cafesilencio force-pushed the sb-qa-app-update branch 2 times, most recently from b1fd851 to ede499c Compare May 26, 2021 19:40
@cafesilencio
Copy link
Contributor Author

Good to remove the one in the examples?

yes, removed.

@cafesilencio cafesilencio merged commit 3c98f6b into main May 26, 2021
@cafesilencio cafesilencio deleted the sb-qa-app-update branch May 26, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Assignees
No one assigned
Labels
skip changelog Should not be added into version changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cafesilencio @LukasPaczos