[Drop-In UI] fix road label position not updating in some cases #6508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zayankovsky
added
bug
Zayankovsky
force-pushed
the
vz-fix-road-label-issue
branch
from
1509057
to
f5ca6f5
Compare
tomaszrybakiewicz
changed the title
tomaszrybakiewicz
approved these changes
Oct 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #6508 +/- ##
=========================================
Coverage 70.33% 70.33%
Complexity 4909 4909
=========================================
Files 717 717
Lines 27951 27951
Branches 3295 3295
=========================================
Hits 19660 19660
Misses 7013 7013
Partials 1278 1278
|
Zayankovsky
force-pushed
the
vz-fix-road-label-issue
branch
from
f5ca6f5
to
a0d64d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was able to reproduce the issue only in 1TAP. In some cases
OnLayoutChangeListeneris not invoked, unlikeOnGlobalLayoutChangeListener. Also I disabled peek height change animations, because they don't work if you update info panel content at the same time (which I believe is a common case) and they cause issues if developer uses transitions for updating info panel content (in which case peek height change is animated already). This is how transitions look in 1TAP:video.mp4