Update electronic horizon example to new API #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovalex
force-pushed
the
azarovalex/update-electronic-horizon-api
branch
from
979395c
to
a63a8f1
Compare
azarovalex
commented
Apr 29, 2021
| navigationMapView.mapView.update { | ||
| $0.location.puckType = .puck2D() | ||
| } | ||
| navigationMapView.mapView.on(.styleLoaded) { [weak self] _ in | ||
| self?.setupMostProbablePathStyle() | ||
| } | ||
|
|
||
| // TODO: Provide a reliable way of setting camera to current coordinate. | ||
| DispatchQueue.main.asyncAfter(deadline: .now() + 1.0) { |
There was a problem hiding this comment.
In the latest NavSDK version camera API was changed and this code doesn't compile anymore.
This code will be rewritten using new API here: #101
|
Shall we separate changes related to SwiftLint and Electronic Horizon? (e.g. move changes which are needed for SwiftLint to another PR)? I think camera related changes already landed to |
|
@azarovalex mind reviving this PR? |
|
After updating this PR with the latest changes from the main it looks like the main branch already has all the changes, so I'll close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electronic horizon public API was changed here mapbox/mapbox-navigation-ios#2906.
This PR changes the "Upcoming intersections" example to use the new API.