Depend on map SDK v5.0.x specifically #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapbox/mapbox-gl-native#14664 will introduce a significant change in rendering behavior in map SDK v5.1.0, obviating the workaround in #1845. As of #2133, the navigation SDK depends on v5.x, which means
pod installandcarthage bootstrapwill automatically pull in v5.1.0. The workaround will clash with the upstream fix, resulting in an unusable map on CarPlay and other situations where there’s a large left or right content inset.This change tightens the dependency to v5.0.x, allowing only patch releases, to avoid surprises when installing the SDK. Once map SDK v5.1.0 comes out, we’ll land #2134 to remove our workaround. This assumes mapbox/mapbox-gl-native#12818 is fixed either in v5.1.0 or deferred until v6.0.0. Otherwise, if that issue is fixed in another minor release of v5.x, the navigation SDK will be prevented from upgrading beyond v5.0.x.
/cc @mapbox/navigation-ios @mapbox/maps-ios @coxchapman @andrewychen