-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude Twitter reachability test from CocoaPods installation test #2188
Conversation
@@ -96,6 +96,7 @@ jobs: | |||
- when: | |||
condition: << parameters.lint >> | |||
steps: | |||
- run: find . -path '*.podspec' -exec perl -pi -e 's/.+\.social_media_url.+//' {} \; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit unfortunate if we have to allow warnings. I wonder if we can work around it by serving a dummy url locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line simply removes the social media URL but doesn’t affect other warnings that would arise. Serving a dummy URL would have exactly the same effect.
The linter is now complaining about warnings that are cropping up from mapbox/mapbox-gl-native#14959:
This is a good demonstration of the linting test’s value: normally I’m used to running |
Split out the deprecation warning fixes as #2192. |
Before linting the podspecs as part of the CocoaPods installation test, remove @mapbox from the podspecs, keeping CocoaPods from checking whether Twitter is reachable. (It is, trust me.)
Fixes #2187.
/cc @mapbox/navigation-ios