Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Twitter reachability test from CocoaPods installation test #2188

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jul 26, 2019

Before linting the podspecs as part of the CocoaPods installation test, remove @mapbox from the podspecs, keeping CocoaPods from checking whether Twitter is reachable. (It is, trust me.)

Fixes #2187.

/cc @mapbox/navigation-ios

@1ec5 1ec5 added build Issues related to builds and dependency management. CocoaPods labels Jul 26, 2019
@1ec5 1ec5 added this to the v0.36.0 milestone Jul 26, 2019
@1ec5 1ec5 requested review from frederoni and JThramer July 26, 2019 00:33
@1ec5 1ec5 self-assigned this Jul 26, 2019
@@ -96,6 +96,7 @@ jobs:
- when:
condition: << parameters.lint >>
steps:
- run: find . -path '*.podspec' -exec perl -pi -e 's/.+\.social_media_url.+//' {} \;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unfortunate if we have to allow warnings. I wonder if we can work around it by serving a dummy url locally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line simply removes the social media URL but doesn’t affect other warnings that would arise. Serving a dummy URL would have exactly the same effect.

@1ec5
Copy link
Contributor Author

1ec5 commented Jul 26, 2019

The linter is now complaining about warnings that are cropping up from mapbox/mapbox-gl-native#14959:

 -> MapboxNavigation (0.35.0)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | [iOS] xcodebuild:  note: Planning build
    - NOTE  | [iOS] xcodebuild:  note: Constructing build description
    - NOTE  | [iOS] xcodebuild:  warning: Capabilities for App may not function correctly because its entitlements use a placeholder team ID. To resolve this, select a development team in the build settings editor. (in target 'App')
    - WARN  | xcodebuild:  /Users/distiller/project/MapboxNavigation/CarPlayManager.swift:359:21: warning: 'setUserTrackingMode(_:animated:)' is deprecated: Use `-setUserTrackingMode:animated:completionHandler:` instead.
    - WARN  | xcodebuild:  /Users/distiller/project/MapboxNavigation/CarPlayManager.swift:633:17: warning: 'setContentInset(_:animated:)' is deprecated: Use `-setContentInset:animated:completionHandler:` instead.
    - WARN  | xcodebuild:  /Users/distiller/project/MapboxNavigation/CarPlayMapViewController.swift:46:27: warning: 'setUserTrackingMode(_:animated:)' is deprecated: Use `-setUserTrackingMode:animated:completionHandler:` instead.
    - WARN  | xcodebuild:  /Users/distiller/project/MapboxNavigation/CarPlayMapViewController.swift:207:17: warning: 'setContentInset(_:animated:)' is deprecated: Use `-setContentInset:animated:completionHandler:` instead.
    - WARN  | xcodebuild:  /Users/distiller/project/MapboxNavigation/CarPlayMapViewController.swift:210:21: warning: 'setUserTrackingMode(_:animated:)' is deprecated: Use `-setUserTrackingMode:animated:completionHandler:` instead.
    - WARN  | xcodebuild:  /Users/distiller/project/MapboxNavigation/CarPlayNavigationViewController.swift:190:17: warning: 'setContentInset(_:animated:)' is deprecated: Use `-setContentInset:animated:completionHandler:` instead.
    - WARN  | xcodebuild:  /Users/distiller/project/MapboxNavigation/NavigationMapView.swift:446:9: warning: 'setUserTrackingMode(_:animated:)' is deprecated: Use `-setUserTrackingMode:animated:completionHandler:` instead.
    - WARN  | xcodebuild:  /Users/distiller/project/MapboxNavigation/RouteMapViewController.swift:336:17: warning: 'setContentInset(_:animated:)' is deprecated: Use `-setContentInset:animated:completionHandler:` instead.
    - NOTE  | xcodebuild:  note: detected encoding of input file as Unicode (UTF-8)

[!] MapboxNavigation did not pass validation, due to 8 warnings (but you can use `--allow-warnings` to ignore them).

This is a good demonstration of the linting test’s value: normally I’m used to running carthage bootstrap in this project, but that would currently get me map SDK v5.1.0 whereas developers using pod install or carthage bootstrap from other projects would get v5.2.0 with the deprecations.

@1ec5
Copy link
Contributor Author

1ec5 commented Jul 26, 2019

Split out the deprecation warning fixes as #2192.

@1ec5 1ec5 merged commit 213c8dd into master Jul 26, 2019
@1ec5 1ec5 deleted the 1ec5-lint-fail-whale-2187 branch July 26, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to builds and dependency management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CocoaPods installation test fails — Twitter is not reachable
4 participants