Require map SDK v5.6.0 #2302
Merged
Require map SDK v5.6.0 #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 9, 2020 13:20
…typed key, going to try and see if we can make the symbol for that public.
rclee
reviewed
Jan 9, 2020
1ec5
commented
Jan 10, 2020
| @@ -85,9 +85,8 @@ open class NavigationEventsManager: NSObject { | |||
| func start() { | |||
| let eventLoggingEnabled = UserDefaults.standard.bool(forKey: NavigationMetricsDebugLoggingEnabled) | |||
|
|
|||
| mobileEventsManager.isDebugLoggingEnabled = eventLoggingEnabled | |||
| mobileEventsManager.isMetricsEnabledInSimulator = true | |||
There was a problem hiding this comment.
We decided to remove this setting for the same reason expressed in #304 (review). If navigation events do need to be sent while running in the simulator, we can reenable that workflow in a separate PR.
1ec5
added
the
backwards incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change requires map SDK v5.6.x–v5.x. It targets the v1.0.x release series.
By comparison, #2301 requires v5.5.x and targets the v0.37.x release series.
Fixes #2299.
/cc @mapbox/navigation-ios @mapbox/maps-ios @mapbox/mobile-telemetry