Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require map SDK v5.5.0 in v0.37.x (redux) #2317

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Require map SDK v5.5.0 in v0.37.x (redux) #2317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changes to the Mapbox Navigation SDK for iOS

## v0.37.2

* Fixed a crash on launch if this SDK is installed using Carthage. ([#2317](https://github.com/mapbox/mapbox-navigation-ios/pull/2317))

## v0.37.1

* Fixed a crash on launch if this SDK is installed using Carthage. ([#2301](https://github.com/mapbox/mapbox-navigation-ios/pull/2301))
Expand Down
2 changes: 1 addition & 1 deletion Cartfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" ~> 5.5.0
binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" == 5.5.0
binary "https://www.mapbox.com/ios-sdk/MapboxNavigationNative.json" ~> 6.2.1
github "mapbox/MapboxDirections.swift" ~> 0.30.0
github "mapbox/turf-swift" ~> 0.3
Expand Down
4 changes: 2 additions & 2 deletions Cartfile.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" "5.5.0"
binary "https://www.mapbox.com/ios-sdk/MapboxNavigationNative.json" "6.2.1"
github "AndriiDoroshko/SnappyShrimp" "1.6.4"
github "CedarBDD/Cedar" "v1.0"
github "Quick/Nimble" "v8.0.2"
github "Quick/Quick" "v2.1.0"
github "Quick/Nimble" "v8.0.5"
github "Quick/Quick" "v2.2.0"
github "ceeK/Solar" "2.1.0"
github "mapbox/MapboxDirections.swift" "v0.30.0"
github "mapbox/MapboxGeocoder.swift" "v0.10.2"
Expand Down
12 changes: 6 additions & 6 deletions MapboxCoreNavigationTests/CocoaPodsTest/PodInstall/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
PODS:
- Mapbox-iOS-SDK (5.5.0)
- MapboxCoreNavigation (0.37.0):
- MapboxCoreNavigation (0.37.1):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the previous version should be used here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CocoaPods installation test lags official releases by design. We haven’t released v0.37.2 yet, so the test can’t verify that running pod update would install v0.37.2. However, it would detect if a newer dependency would be pulled in. This is why the test has failed quite often during the v1.0 development process, as breaking changes were introduced between prereleases of MapboxDirections.

- MapboxDirections.swift (~> 0.30.0)
- MapboxMobileEvents (~> 0.9.5)
- MapboxNavigationNative (~> 6.2.1)
- Turf (~> 0.3.0)
- MapboxDirections.swift (0.30.0):
- Polyline (~> 4.2)
- MapboxMobileEvents (0.9.5)
- MapboxNavigation (0.37.0):
- Mapbox-iOS-SDK (~> 5.5.0)
- MapboxCoreNavigation (= 0.37.0)
- MapboxNavigation (0.37.1):
- Mapbox-iOS-SDK (= 5.5.0)
- MapboxCoreNavigation (= 0.37.1)
- MapboxSpeech (~> 0.1.0)
- Solar (~> 2.1)
- MapboxNavigationNative (6.2.1)
Expand Down Expand Up @@ -42,10 +42,10 @@ EXTERNAL SOURCES:

SPEC CHECKSUMS:
Mapbox-iOS-SDK: 7fa66a27e586acb14c7f32ec5a487343e3994451
MapboxCoreNavigation: d77f31673d8d00b56f37863322ea8c16e3b5492b
MapboxCoreNavigation: 068b9a5dee2eb963ed207d585456ad50d655f9fc
MapboxDirections.swift: 1c6df988c24b753888ebd9976d7c98632501a413
MapboxMobileEvents: f6c21b2e59066c5c7093585de7c15adae3b63da0
MapboxNavigation: e426d86d172fe8a6535a229bde6d437a73c57851
MapboxNavigation: 7d32093cef0c05c22db48ce92ec8c2cdfdfc8207
MapboxNavigationNative: 11dc22140f4698d3f26989f2b6379dc81ef0d4c1
MapboxSpeech: 59b3984d3f433a443d24acf53097f918c5cc70f9
Polyline: 0e9890790292741c8186201a536b6bb6a78d02dd
Expand Down
2 changes: 1 addition & 1 deletion MapboxNavigation-Documentation.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Pod::Spec.new do |s|

s.dependency "MapboxDirections.swift", "~> 0.30.0"
s.dependency "MapboxGeocoder.swift", "~> 0.10.0"
s.dependency "Mapbox-iOS-SDK", "~> 5.5.0"
s.dependency "Mapbox-iOS-SDK", "= 5.5.0"
s.dependency "MapboxMobileEvents", "~> 0.9.5"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also pin MapboxMobileEvents to v0.9.5 specifically and avoid patch releases? Unlike with the map SDK, this branch is still on a pre-v1.0 release, so it wouldn’t float to v0.10.x.

/cc @rclee @alfwatt

s.dependency "Solar", "~> 2.1"
s.dependency "Turf", "~> 0.3.0"
Expand Down
2 changes: 1 addition & 1 deletion MapboxNavigation.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Pod::Spec.new do |s|
s.module_name = "MapboxNavigation"

s.dependency "MapboxCoreNavigation", "#{s.version.to_s}"
s.dependency "Mapbox-iOS-SDK", "~> 5.5.0"
s.dependency "Mapbox-iOS-SDK", "= 5.5.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CocoaPods wasn’t affected by the original issue, but I’m pinning the podspec too to ensure consistent dependencies regardless of the dependency manager used.

s.dependency "Solar", "~> 2.1"
s.dependency "MapboxSpeech", "~> 0.1.0"

Expand Down