Rework Feedback UI assets to allow tinting. #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Jul 6, 2020
| @@ -36,6 +44,7 @@ class FeedbackCollectionViewCell: UICollectionViewCell { | |||
| func commonInit() { | |||
| setupViews() | |||
| setupConstraints() | |||
| circleColor = .black | |||
There was a problem hiding this comment.
Instead of black, can we have the default tint color be the tint color of the surrounding view controller?
|
The other build bots are failing because of a compiler error: |
|
It looks like #2421 needs to be rebased onto release-v1.0-pre-registry. Once it gets rebased, the tests will no longer need to build on Xcode 10 where they’re failing. |
|
#2441 tracks the CarPlay test crash. |
avi-c
force-pushed
the
nishantk/feedbackOverhaulPt3
branch
from
a2599fa
to
29addd0
Compare
avi-c
force-pushed
the
ac-FeedbackIconArtRetarget
branch
from
15d8c81
to
73b22e2
Compare
Base automatically changed from
nishantk/feedbackOverhaulPt3
to
release-v1.0-pre-registry
July 7, 2020 17:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for PR #2435
Needed because I incorrectly targeted nishantk/feedbackOverhaulPt4, in that PR and merged it in, which I since reverted from that branch.