Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podtest #2652

Closed
wants to merge 1 commit into from
Closed

Podtest #2652

wants to merge 1 commit into from

Conversation

frederoni
Copy link
Contributor

@frederoni frederoni commented Sep 25, 2020

testing…

@1ec5
Copy link
Contributor

1ec5 commented Sep 25, 2020

The Xcode_12.0_iOS_14.0 build is failing with these non-fatal warnings, which can be bypassed:

 -> MapboxCoreNavigation (1.0.0)
    - ERROR | [iOS] xcodebuild: Returned an unsuccessful exit code.
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Building targets in parallel
    - NOTE  | xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | [iOS] xcodebuild:  note: Planning build
    - NOTE  | [iOS] xcodebuild:  note: Constructing build description
    - NOTE  | [iOS] xcodebuild:  warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99. (in target 'MapboxMobileEvents' from project 'Pods')
    - NOTE  | [iOS] xcodebuild:  warning: Capabilities for Signing & Capabilities may not function correctly because its entitlements use a placeholder team ID. To resolve this, select a development team in the App editor. (in target 'App' from project 'App')
    - NOTE  | [iOS] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')
    - NOTE  | [iOS] xcodebuild:  warning: [CP] Unable to find matching .xcframework slice in 'MapboxCommon/MapboxCommon.xcframework MapboxCommon framework ios-armv7_arm64/MapboxCommon.framework ios-x86_64-simulator/MapboxCommon.framework ios-x86_64-maccatalyst/MapboxCommon.framework' for the current build architectures (arm64 i386 x86_64).

[!] MapboxCoreNavigation did not pass validation, due to 1 error.
You can use the `--no-clean` option to inspect any issue.

However, that isn’t the same as the error that’s blocking us from pushing v1.0.0 to CocoaPods trunk.

@frederoni frederoni changed the title Run linters with newer versions of Xcode Podtest Sep 28, 2020
@1ec5
Copy link
Contributor

1ec5 commented Sep 28, 2020

I get the same warning locally:

 -> MapboxCoreNavigation (1.0.0)
    - ERROR | [iOS] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Building targets in parallel
    - NOTE  | xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | [iOS] xcodebuild:  note: Planning build
    - NOTE  | [iOS] xcodebuild:  note: Constructing build description
    - NOTE  | [iOS] xcodebuild:  warning: [CP] Unable to find matching .xcframework slice in 'MapboxCommon/MapboxCommon.xcframework MapboxCommon framework ios-armv7_arm64/MapboxCommon.framework ios-x86_64-simulator/MapboxCommon.framework ios-x86_64-maccatalyst/MapboxCommon.framework' for the current build architectures (arm64 i386 x86_64).
    - NOTE  | xcodebuild:  ld: warning: directory not found for option '-F/Users/mxn/Library/Developer/Xcode/DerivedData/App-gzpbjyhxafsnrkgfcryvlcwdbyay/Build/Products/Release-iphonesimulator/XCFrameworkIntermediates/MapboxCommon'
    - NOTE  | xcodebuild:  clang: error: linker command failed with exit code 1 (use -v to see invocation)
    - NOTE  | [iOS] xcodebuild:  warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99. (in target 'Polyline' from project 'Pods')
    - NOTE  | [iOS] xcodebuild:  warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99. (in target 'MapboxMobileEvents' from project 'Pods')
    - NOTE  | [iOS] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')

I’m assuming this is something I can get around using --allow-warnings, as opposed to the error that I was seeing in #2646 (comment).

@1ec5
Copy link
Contributor

1ec5 commented Sep 29, 2020

The linter issues were fixed with MapboxCommon v4.0.1 in CocoaPods/Specs@0c4ffe7 and MapboxNavigationNative v18.0.5 in CocoaPods/Specs@79b290a. We just need to update the navigation-native dependency in the Cartfile and we’ll be able to continue with the v1.0.0 release in #2646.

@1ec5 1ec5 closed this Sep 29, 2020
@1ec5 1ec5 deleted the fred/pod-test branch September 29, 2020 15:18
MaximAlien added a commit that referenced this pull request Oct 26, 2020
…pport"

This reverts commit 080ac48, reversing
changes made to 2a4489c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants