Electronic horizon #2834
Merged
Electronic horizon #2834
Commits on Mar 15, 2021
-
-
-
-
-
-
-
-
-
Inline object type when associated with metadata
Replaced mutually exclusive properties with associated values. Deleted provider enumeration because it is sufficiently represented by the presence of an associated value.
-
-
Reuse Mapbox Streets road classifications
Reuse Mapbox Streets road classifications for consistency with the Directions API.
-
-
-
Removed user-defined road object interface
Removed the unimplemented interface for adding and removing user-defined road objects but retained the corresponding type enumeration cases for future use.
-
Added property for e-horizon configuration
Replaced the lone setter for e-horizon configuration with a read-write property that stores the last set value (since MapboxNavigationNative doesn’t expose a getter).
-
Spelled out words in interfaces
Spelled out “identifier”, “minimum”, and “outlet”.
-
-
-
-
Type speed limit as a measurement
The navigator only measures the speed limit in meters per second, but for forward-compatibility, this change uses the Measurement type to allow for localized units in the future. For now, the code unconditionally converts to kilometers per hour.
-
-
-
Spelled out the “electronic” in “electronic horizon”. Nested several e-horizon types under other types for less repetitiveness. Removed “electronic horizon” from the name of several types to align with a separate naming convention for things related to the road graph.
-
-
-
-
-
-
Replaced ElectronicHorizonDelegate with notifications
Electronic horizon updates come from an internal singleton, so exposing them through delegates of RouteController and PassiveLocationDataSource could result in redundancy or contention. Instead, funnel the updates through the Navigator singleton and post notifications. Flattened some notification-specific classes and structs into notification user info dictionaries. Consolidated creation of RouteObjectsStore wrapper object.
-
-
Converted RoadName to associated-value enumeration
The name and code are mutually exclusive; an edge identified by both a name and a code would have two RoadNames in its names array.
-
-
-
Renamed ElectronicHorizon.Edge.functionalRoadClass to mapboxStreetsRoadClass for consistency with Intersection.mapboxStreetsRoadClass. Mapbox Streets makes slightly different distinctions than OpenStreetMap’s raw highway tags (which aren’t necessarily strictly functional anyways).
-
-
-
-
-
Removed redundant teardown of e-horizon observer
The Navigator singleton is already theoretically responsible for tearing down the e-horizon observer, though in practice that will never happen because it’s a singleton. Regardless, it would be inappropriate for RouteController or PassiveLocationDataSource to tear it down because that’s Navigator’s responsibility.
-
-
The result type type merely distinguishes an initial revision from an update. A Boolean-typed key is more explicit. As additional states become necessary, we can update the user info dictionary as necessary.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.