Store current road details in map view controller #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to use this mechanism for the upcoming road, we’d need to somehow load the tile around the maneuver point off-screen and query that tile for a matching road. It seems like overkill, but the Maps API’s tile query method would give us what we need here. |
RouteMapViewController now stores the current road name and synchronizes it with the label that displays the name.
1ec5
force-pushed
the
1ec5-current-name-class
branch
from
612d06c
to
00e96bb
Compare
ericrwolfe
added
general: experimental
and removed
⚠️ DO NOT MERGE
|
Tagged as experimental and closing for now. Will revisit when we explore implementing custom navigation road labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RouteMapViewController now stores the current name and classification of the current road, based on the same process by which the current road name label is populated. Eventually, perhaps RouteVoiceController could somehow gain access to this information so that it could word and time voice announcements differently on freeways versus surface streets.
At first glance, this might also look like a good solution to #291 (comment), Project-OSRM/osrm-text-instructions#51, and #286 (comment). However, this feature querying mechanism only gives us information about the road the user is currently traveling on, not the one the user needs to turn onto.
/cc @bsudekum @frederoni