New car play change colors logic #4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovalex
reviewed
Apr 2, 2024
azarovalex
reviewed
Apr 2, 2024
API compatibility report for MapboxNavigation: 🔴Protocol Requirement Change
|
azarovalex
reviewed
Apr 2, 2024
azarovalex
reviewed
Apr 2, 2024
chizhavko
force-pushed
the
new-carplay-change-background-color-logic
branch
from
d1d8fae
to
677ceff
Compare
azarovalex
reviewed
Apr 2, 2024
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## release-v2.18 #4620 +/- ##
=================================================
- Coverage 60.54% 60.51% -0.03%
=================================================
Files 189 189
Lines 21297 21307 +10
=================================================
Hits 12894 12894
- Misses 8403 8413 +10
|
azarovalex
reviewed
Apr 2, 2024
| primaryManeuver.symbolSet = visualInstruction.primaryInstruction.maneuverImageSet(side: visualInstruction.drivingSide) | ||
| } | ||
|
|
||
| primaryManeuver.symbolSet = visualInstruction.primaryInstruction.maneuverImageSet(side: visualInstruction.drivingSide) |
There was a problem hiding this comment.
for history, some info on why we made this change.
From Apple CarPlay development guide:
If the maneuver has an associated symbol, such as a turn right arrow, provide an image
using symbolSet. [...] You must provide two image variants using CPImageSet—one is used for rendering
the symbol on light backgrounds, the other is used for rendering the symbol on dark backgrounds.
Since we don't know which custom background color a developer might provide, we always use symbolSet to pass both white and dark symbols for maneuvers, CarPlay will choose a better version on its own.
volkdmitri
approved these changes
Apr 3, 2024
Sources/MapboxNavigation/CarPlayNavigationViewControllerDelegate.swift
Outdated
Show resolved
Hide resolved
API compatibility report for MapboxNavigation: 🔴Protocol Requirement Change
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce new logic related to configuration to set custom colors to
CPMapTemplate.guidanceBackgroundColorusing new delegate method:CarPlayNavigationViewControllerDelegate.carPlayNavigationViewController(_:guidanceBackgroundColor:)