Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Carthage support #10

Open
jmkiley opened this issue Sep 8, 2017 · 3 comments
Open

Add Carthage support #10

jmkiley opened this issue Sep 8, 2017 · 3 comments
Assignees

Comments

@jmkiley
Copy link
Contributor

jmkiley commented Sep 8, 2017

Currently the Mapbox Maps Plugins can be installed via CocoaPods or manually. Carthage support should also be offered.

@jmkiley jmkiley self-assigned this Sep 8, 2017
@jmkiley jmkiley mentioned this issue Sep 8, 2017
4 tasks
@1ec5
Copy link
Contributor

1ec5 commented Sep 8, 2017

#9 introduces subspecs. Per mapbox/mapbox-navigation-ios#108, it probably won’t be possible to use subspecs while supporting Carthage.

@jmkiley
Copy link
Contributor Author

jmkiley commented Sep 8, 2017

Good to know, thanks! We could go back to individual podspecs, then offer bundled podspec later that installs all plugins. 🤔 Would multiple podspecs pose an issue once we have more plugins?

@1ec5
Copy link
Contributor

1ec5 commented Sep 8, 2017

Yeah, I could see multiple podspecs being a royal pain to maintain. Even just pushing two podspecs for the navigation SDK project to CocoaPods trunk is a bit error-prone. (I always forget to run the slow pod spec update process between each podspec push.)

This plugins project would be the perfect fit for subspecs, but the root of the problem is that it’s incompatible with Xcode’s project model. It might still be possible to hack around the problem, as long as we’re really judicious about imports. That might mean eliminating PluginKit entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants