Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapboxNavigation and MapboxCoreNavigation should be subspecs #108

Closed
1ec5 opened this issue Mar 30, 2017 · 1 comment
Closed

MapboxNavigation and MapboxCoreNavigation should be subspecs #108

1ec5 opened this issue Mar 30, 2017 · 1 comment
Labels
build Issues related to builds and dependency management.

Comments

@1ec5
Copy link
Contributor

1ec5 commented Mar 30, 2017

There should only be one podspec in this repository, not two, and it should contain two subspecs – one for the UI stuff and one for the non-UI stuff. That’ll makes it more efficient to install the entire navigation SDK via CocoaPods. Not clear whether both subspecs should be included by default.

I’d consider this a blocker for publishing the podspecs on CocoaPods.org, because there isn’t a real way to remove a pod once it’s up there.

/ref Project-OSRM/osrm-text-instructions.swift#15
/cc @bsudekum @frederoni

@1ec5 1ec5 added build Issues related to builds and dependency management. enhancement labels Mar 30, 2017
@1ec5 1ec5 changed the title MapboxNavigation and MapboxNavigationUI should be subspecs MapboxNavigation and MapboxCoreNavigation should be subspecs Apr 10, 2017
@1ec5
Copy link
Contributor Author

1ec5 commented Apr 14, 2017

I attempted to reimplement MapboxCoreNavigation as a subspec of MapboxNavigation in #140. Unfortunately, it doesn’t appear to be possible to reconcile CocoaPods’ subspec concept with the broader goal of keeping MapboxCoreNavigation and MapboxNavigation in separate frameworks (also needed for Carthage compatibility).

Having investigated this approach and decided against it, we should push the two podspecs to CocoaPods trunk as-is.

@1ec5 1ec5 closed this as completed Apr 14, 2017
wishtrip-dev pushed a commit to wishtrip-dev/mapbox-navigation-ios that referenced this issue Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to builds and dependency management.
Projects
None yet
Development

No branches or pull requests

1 participant